Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=test Switch pattern matching cases in Player. #635

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Sep 6, 2023

A seprated PR to fix #632 & scala/scala3#18519

As the all ServerOp extends NetworkOp

@He-Pin He-Pin mentioned this pull request Sep 6, 2023
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should move the code associated with the case

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit 299484d into apache:main Sep 6, 2023
16 of 17 checks passed
@He-Pin He-Pin deleted the swithOrder branch September 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants